Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination follow ups #4741

Merged
merged 7 commits into from
Sep 21, 2024
Merged

Conversation

akolson
Copy link
Member

@akolson akolson commented Sep 18, 2024

Summary

Description of the change(s) you made

This pr does the following;

  1. Adds padding around the "Show more" pagination button
  2. Streamlines the number of resources show in a particular folder
  3. Makes the "Show more" pagination button responsive when more than 25 resources have been uploaded.

Manual verification steps performed

  1. Login to studio
  2. Navigate to a channel or its folder that has more than 25 resources and observe the behavior
  3. Observe that the resource and question count correspond to what is in the folder and exercise respectively
  4. Also, upload over 25 resources into a folder and try to use the "Show more" button

Screenshots (if applicable)

Padding
image

Resource counts

Screen.Recording.2024-09-18.at.10.57.18.mov

Uploading >25 resources

Screen.Recording.2024-09-18.at.16.23.44.mov

Does this introduce any tech-debt items?

  • No

Reviewer guidance

How can a reviewer test these changes?

  • See manual verification above

Are there any risky areas that deserve extra testing?

  • The pagination feature
  • Critical workflows

References

Fixes #4715
Fixes #4727

Comments

  • There appears to be an existing issue with pagination when importing from channels. After the import process, resources are added in 'copying' state, and this process takes time to complete. When the number of resources exceeds 25, all of them are displayed simultaneously, causing inconsistencies with the display of the 'Show more' button, rendering it non-operational in some cases. The expected behavior for this scenario needs to be clarified and addressed in a separate issue. cc @rtibbles @marcellamaki

Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it worked great. Code LGTM!

@akolson akolson merged commit 09b981d into learningequality:unstable Sep 21, 2024
13 checks passed
@akolson akolson mentioned this pull request Sep 24, 2024
@marcellamaki marcellamaki mentioned this pull request Sep 26, 2024
24 tasks
@akolson akolson mentioned this pull request Oct 1, 2024
@akolson akolson deleted the pagination-follow-ups branch October 31, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants